From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Chapman Flack <chap(at)anastigmatix(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Define jsonpath functions as stable |
Date: | 2019-09-19 19:48:28 |
Message-ID: | 963.1568922508@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Jonathan S. Katz" <jkatz(at)postgresql(dot)org> writes:
> I looked at the patch, but did not test it. From what I can see, it
> looks good, but perhaps we add a test in it to show that single-quoted
> literals are unsupported?
I thought about that, but it seems like it'd be memorializing some
other weird behavior:
regression=# select '''foo'''::jsonpath;
ERROR: syntax error, unexpected IDENT_P at end of jsonpath input
LINE 1: select '''foo'''::jsonpath;
^
regression=# select '''foo'' <= ''bar'''::jsonpath;
ERROR: syntax error, unexpected IDENT_P at or near " " of jsonpath input
LINE 1: select '''foo'' <= ''bar'''::jsonpath;
^
There isn't anything I like about these error messages. Seems like
the error handling in jsonpath_gram.y could use some cleanup too
... although I don't think it's a task to tackle while we're
rushing to get v12 shippable.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Nikita Glukhov | 2019-09-19 21:15:23 | Re: Bug in GiST paring heap comparator |
Previous Message | Alexander Korotkov | 2019-09-19 19:14:38 | Re: Bug in GiST paring heap comparator |