Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, PG Bug reporting form <noreply(at)postgresql(dot)org>
Subject: Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage
Date: 2019-08-08 18:41:42
Message-ID: 9616.1565289702@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andres Freund <andres(at)anarazel(dot)de> writes:
> Seems there's no reason to not zero initialize memory here? But perhaps just by initializing the stack variable?

I think all we need here is another suppression in
src/tools/valgrind.supp. We have not insisted on zeroing
pad bytes that get sent to disk in the places already
enumerated in valgrind.supp, so why would we apply a
different rule to async.c?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2019-08-08 19:12:04 Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage
Previous Message Andres Freund 2019-08-08 18:21:04 Re: BUG #15943: Valgrind-detected error in SlruPhysicalWritePage