Re: syntax error position "CREATE FUNCTION" bug fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: syntax error position "CREATE FUNCTION" bug fix
Date: 2004-03-18 16:07:28
Message-ID: 9577.1079626048@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> Please find attached a patch to fix the "CREATE FUNCTION" syntax error
> position bug I reported a few days ago.

This strikes me as much too intrusive to be worthwhile ... the problem
is simply not important enough to justify a protocol change. Moreover,
I don't like the proposed protocol change anyway. This approach only
solves the problem for psql-like error reporting, namely clients that
are going to regurgitate a string in their error message and aren't
very picky about whether that string really matches the original input.
One of the design goals for the error reporting feature is that GUI-type
clients should be able to mark syntax error positions by highlighting in
the original input window. This proposal abandons that goal.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-03-18 16:16:29 Re: COPY formatting
Previous Message Tom Lane 2004-03-18 15:25:45 Re: Problem on cluster initialization

Browse pgsql-patches by date

  From Date Subject
Next Message Fabien COELHO 2004-03-18 16:51:45 Re: syntax error position "CREATE FUNCTION" bug fix
Previous Message Fabien COELHO 2004-03-18 09:51:36 syntax error position "CREATE FUNCTION" bug fix