| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix alter subscription concurrency errors |
| Date: | 2023-03-20 18:00:44 |
| Message-ID: | 956468.1679335244@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com> writes:
> Hm. This patch is still waiting on updates. But it's a bug fix and it
> would be good to get this in. Is someone else interested in finishing
> this if Jeite isn't available?
I think the patch as-submitted is pretty uninteresting, mainly because the
design of adding bespoke lock code for subscription objects doesn't scale.
I'm not excited about doing this just for subscriptions without at least a
clear plan for working on other object types.
Alvaro suggested switching it to use get_object_address() instead, which'd
be better; but before going in that direction we might have to do more
work on get_object_address's error reporting (note the para in its header
comments saying it's pretty weak on that).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-20 18:13:23 | Re: Save a few bytes in pg_attribute |
| Previous Message | Gregory Stark (as CFM) | 2023-03-20 17:59:32 | Re: Fix order of checking ICU options in initdb and create database |