Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Indexes with INCLUDE columns and their support in B-tree
Date: 2018-04-08 16:58:47
Message-ID: 95278363-d49f-a5e3-106f-d92fac547e19@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Thank you, pushed

Alexander Korotkov wrote:
> On Sun, Apr 8, 2018 at 5:41 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
> Teodor Sigaev <teodor(at)sigaev(dot)ru <mailto:teodor(at)sigaev(dot)ru>> writes:
> > Indexes with INCLUDE columns and their support in B-tree
>
> The valgrind-using animals seem to think this broke stuff.
> There are at least two different problems here:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-04-07%2020%3A03%3A02
> <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-04-07%2020%3A03%3A02>
>
>
> I think attached patch should fix one of those problems.
> We should match clauses to only key columns of index.
> I will further investigate the problem with CheckIndexCompatible().
>
> ------
> Alexander Korotkov
> Postgres Professional:http://www.postgrespro.com
> <http://www.postgrespro.com/>
> The Russian Postgres Company

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-08 17:17:44 pgsql: Replace our traditional initial-catalog-data format with a bette
Previous Message Teodor Sigaev 2018-04-08 16:58:31 pgsql: match_clause_to_index should check only key columns