Re: ALTER TABLE: warn when actions do not recurse to partitions

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
Date: 2026-01-14 00:52:18
Message-ID: 950BB7B5-0180-4C36-82A0-7E17B920F740@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jan 13, 2026, at 19:16, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
>
> Hi Chao
>
> On 13/01/2026 05:02, Chao Li wrote:
>>
>> PSA v3:
>>
>> * Rephrased the notice message as David's suggestion.
>> * Removed partition count from notice message.
>> * If a partitioned table doesn't have any partition, then suppress the
>> message.
>
> I've been playing with this patch, and it seems to work as expected -
> I'm surprised it didn't break any existing tests :). Do you plan to
> extend this patch to other subcommands mentioned in your initial post,
> such as SET STATISTICS?
>
> Thanks for the patch
>
> Best, Jim
>

Hi Jim,

Thanks for your testing. Yes, I plan to add the notice to other sub-commands as needed. I only updated REPLICA IDENTITY first to call for feedback. As you see, David has suggested the great wording for the notice message. Once the change on REPLICA IDENTITY is reviewed, it’s easy to extend to other sub-commands.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-01-14 01:01:48 Re: pg_stat_statements: Fix nested tracking for implicitly closed cursors
Previous Message Andres Freund 2026-01-14 00:49:00 Re: Buffer locking is special (hints, checksums, AIO writes)