Re: Wrap access to Oid in HeapTupleHeader

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Manfred Koizar <mkoi-pg(at)aon(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Wrap access to Oid in HeapTupleHeader
Date: 2002-07-01 13:46:41
Message-ID: 9501.1025531201@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Manfred Koizar <mkoi-pg(at)aon(dot)at> writes:
> it indroduces two
> pre-conditions for accessing the oid:
> . the relation has oids
> . the heap tuple header is already formatted, i.e. t_hoff is valid

I think the latter test is unnecessary and potentially dangerous;
it could break code that tries to access OID in a
not-yet-completely-built header. The test that insists t_hoff is valid
before one can *set* OID is even more likely to cause trouble.
I do not see the point of this in any case.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-07-01 13:47:32 Re: Changes in /contrib/fulltextindex
Previous Message Manfred Koizar 2002-07-01 10:01:44 Wrap access to Oid in HeapTupleHeader