Re: Fix incorrect function comment of stringToNodeInternal

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix incorrect function comment of stringToNodeInternal
Date: 2025-09-25 09:54:30
Message-ID: 94AE51FC-94AB-43A0-8EFE-628E9E8AC9D0@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 25 Sep 2025, at 10:01, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:

> There are 5 different cases, showing that there is not a unique way for what function name should be put to xxInternal() functions’ comment.
>
> Is it deserve to take this opportunity to make all of them in a consistent format?

We don't have a policy on how to do function comments, and none of these
examples strike me as particularly confusing. I don't think there is much
value in the churn from changing these from one flavor or another as they
aren't wrong.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-09-25 10:09:44 Re: Fix incorrect function comment of stringToNodeInternal
Previous Message Álvaro Herrera 2025-09-25 09:46:28 Re: NOT NULL NOT ENFORCED