| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Potentially misleading name of libpq pass phrase hook |
| Date: | 2020-05-17 01:16:34 |
| Message-ID: | 944f7b71-9ec7-f780-956c-9bf3871a62fd@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/16/20 7:47 PM, Tom Lane wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>> On 16 May 2020, at 03:56, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>> Agreed. PQsslKeyPassHook_<library>_type sounds fine to me as
>>> convention. Wouldn't we want to also rename PQsetSSLKeyPassHook and
>>> PQgetSSLKeyPassHook, appending an "_OpenSSL" to both?
>> Yes, I think we should. The attached performs the rename of the hook functions
>> and the type, and also fixes an off-by-one-'=' in a header comment which my OCD
>> couldn't unsee.
> The patch as committed missed renaming PQgetSSLKeyPassHook() itself,
> but did rename its result type, which seemed to me to be clearly
> wrong. I took it on myself to fix that up, and also to fix exports.txt
> which some of the buildfarm insists be correct ;-)
>
>
argh! thanks!
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-05-17 02:22:16 | Re: Add A Glossary |
| Previous Message | Jack Christensen | 2020-05-17 01:12:27 | Performance penalty when requesting text values in binary format |