| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Continue work on changes to recovery.conf API |
| Date: | 2018-10-12 16:15:22 |
| Message-ID: | 943181539360922@iva4-24c534b4e3ac.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
I complete new version of this patch. I've attached it.
In this version i remove proposed recovery_target_type/recovery_target_value and implement set of current settings: recovery_target (immediate), recovery_target_name, recovery_target_time, recovery_target_xid, recovery_target_lsn
>>> - trigger_file was renamed to promote_signal_file for clarify (my change, in prev thread was removed)
>>
>> OK to add the "promote" prefix, but I'd prefer to keep the "trigger"
>> name. There is a lot of discussion and knowledge around that. Seems
>> unnecessary to change.
>
> Ok, will change to promote_trigger_file
Renamed to promote_trigger_file
Possible we need something like separate xlog_guc.c and header for related functions and definition?
regards, Sergei
| Attachment | Content-Type | Size |
|---|---|---|
| new_recovery_api_v004.patch | text/x-diff | 98.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-12 16:20:42 | Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel |
| Previous Message | Andres Freund | 2018-10-12 15:58:21 | Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel |