Re: Oddity in error handling of constraint violation in ExecConstraints for partitioned tables

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Oddity in error handling of constraint violation in ExecConstraints for partitioned tables
Date: 2017-07-24 08:30:08
Message-ID: 93ba6de4-5669-5111-99ac-d7b6dcefb847@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/07/24 16:16, Amit Khandekar wrote:
> On 24 July 2017 at 12:11, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Attached is the updated version of your patch.

Good catch, Amit K. and Amit L.!

> Now that this is done, any particular reason it is not done in
> ExecPartitionCheck() ? I see that there is a do_convert_tuple() in
> that function, again without changing the slot descriptor.

Yeah, I think we would need that in ExecPartitionCheck() as well.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sokolov Yura 2017-07-24 09:37:25 Re: Increase Vacuum ring buffer.
Previous Message scott 2017-07-24 07:22:40 BUG #14758: Segfault with logical replication on a function index