| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix tab-completion of ALTER SUBSCRIPTION SET PUBLICATION |
| Date: | 2017-06-09 14:18:34 |
| Message-ID: | 9399a85a-cbcd-d819-fb21-817bb0f82069@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/6/17 23:52, Masahiko Sawada wrote:
> On Wed, Jun 7, 2017 at 12:41 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> On 6/6/17 04:17, Masahiko Sawada wrote:
>>> With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
>>> completes with "REFRESH" and "SKIP REFRESH".
>>> Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
>>> SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.
>>
>> That syntax does not exist anymore.
>>
>> You could add support for the new WITH () syntax.
>>
>
> Sorry, I missed it.
> Attached updated version patch adds WITH() syntax.
Committed, with the addition of the copy_data option.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-06-09 14:31:41 | Re: strcmp() tie-breaker for identical ICU-collated strings |
| Previous Message | Amit Khandekar | 2017-06-09 14:18:03 | Re: UPDATE of partition key |