| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: file cloning in pg_upgrade and CREATE DATABASE |
| Date: | 2018-11-08 07:27:46 |
| Message-ID: | 9391db04-401c-df5f-bbed-48397f9e1798@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/11/2018 19:03, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> Committed, thanks.
>
> It seems unfortunate that there is no test coverage in the committed
> patch. I realize that it may be hard to test given the filesystem
> dependency, but how will we know if it works at all?
You can use something like
PG_UPGRADE_OPTS=--clone make -C src/bin/pg_upgrade check
(--link is similarly untested.)
If we do get the TAP tests for pg_upgrade set up, we can create smaller
and faster test cases for this.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-11-08 07:46:46 | Re: ON COMMIT actions and inheritance |
| Previous Message | Amit Langote | 2018-11-08 07:15:43 | Re: Speeding up INSERTs and UPDATEs to partitioned tables |