From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Subject: | Re: ON COMMIT actions and inheritance |
Date: | 2018-11-08 07:46:46 |
Message-ID: | 38e283e7-6d3e-487d-6235-96a8443c5ff6@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Thank you updating the patch and adding notes to the documentation about
the points I raised.
On 2018/11/07 9:53, Michael Paquier wrote:
> On Tue, Nov 06, 2018 at 07:04:17PM +0900, Amit Langote wrote:
>> Agree with keeping it simple. Maybe, we could (should?) document that the
>> only ON COMMIT action that works when specified with partitioned parent
>> table is DROP (other actions are essentially ignored)?
>
> I have been thinking about this one, and here are some ideas:
> - for ON COMMIT DROP:
> When used on a partitioned table or a table with inheritance children,
> this drops the depending partitions and children.
> - for ON DELETE ROWS:
> When used on a partitioned table, this is not cascaded to its
> partitions.
I looked at the documentation patch regarding this:
@@ -1225,7 +1226,9 @@ WITH ( MODULUS <replaceable
class="parameter">numeric_literal</replaceable>, REM
<listitem>
<para>
The temporary table will be dropped at the end of the current
- transaction block.
+ transaction block. When used on a partitioned table or a
+ table with inheritance children, this drops the depending
+ partitions and children.
How about:
When used on tables with inheritance children (including partitioned
tables), this also drops the children (partitions).
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Konstantin Knizhnik | 2018-11-08 08:08:25 | Re: [HACKERS] Surjective functional indexes |
Previous Message | Peter Eisentraut | 2018-11-08 07:27:46 | Re: file cloning in pg_upgrade and CREATE DATABASE |