Re: import: source code is pushed to git repository

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Quan Zongliang <quanzongliang(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: import: source code is pushed to git repository
Date: 2009-12-22 21:40:12
Message-ID: 937d27e10912221340h3f3e5065g1156b802e160ae6e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Dec 22, 2009 at 9:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> All of them only tested under WindowsXP.
>
> Not so good on Mac yet :-(
>
...
> Seems like oyu need to add <wx/spinctrl.h> to frmImport.h.
>
> <continuing with build now...>

OK, got it to the link phase with the attached patch, but then it died
horribly. I think you need to build your code under gcc every now and
again, to keep it in a nice cross-platform friendly state. It's also a
good idea to catch any problems - gcc tends to be a much less
forgiving compiler than VC++, which will often allow code which will
crash elsewhere (for example, passing wxStrings through variadic
functions such as on line 4304 of frmImport.cpp).

If you don't have a Linux box, I'd suggest grabbing a copy of
VirtualBox for Windows, and installing Ubuntu or Fedora in it.

g++ -DHAVE_CONFIG_H -I. -I.. -I/usr/local/pgsql/include -DSSL
-I/usr/local/lib/wx/include/mac-unicode-release-static-2.8
-I/usr/local/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-D__WXMAC__ -O2 -DEMBED_XRC -no-cpp-precomp -arch ppc -arch i386
-I/usr/local//include/libxml2 -I/usr/local/include
-I/usr/local//include/libxml2 -Wall -Wno-non-virtual-dtor
-fno-strict-aliasing -I../pgadmin/include -c -o frmImport.o `test -f
'./frm/frmImport.cpp' || echo './'`./frm/frmImport.cpp
In file included from ./frm/frmImport.cpp:7:
../pgadmin/include/frm/frmImport.h:67: error: ‘pgTable’ has not been declared
../pgadmin/include/frm/frmImport.h:210: error: ISO C++ forbids
declaration of ‘pgTable’ with no type
../pgadmin/include/frm/frmImport.h:210: error: expected ‘;’ before ‘*’ token
./frm/frmImport.cpp:309: error: ‘pgTable’ has not been declared
./frm/frmImport.cpp: In constructor ‘frmImport::frmImport(frmMain*, int*)’:
./frm/frmImport.cpp:312: error: ‘m_table’ was not declared in this scope
./frm/frmImport.cpp: In member function ‘void frmImport::Init()’:
./frm/frmImport.cpp:381: error: ‘m_table’ was not declared in this scope
./frm/frmImport.cpp:390: error: no matching function for call to
‘wxXmlResource::LoadObject(frmImport* const, frmMain*&, const wchar_t
[10], const wchar_t [9])’
/usr/local/include/wx-2.8/wx/xrc/xmlres.h:201: note: candidates are:
wxObject* wxXmlResource::LoadObject(wxWindow*, const wxString&, const
wxString&)
/usr/local/include/wx-2.8/wx/xrc/xmlres.h:207: note:
bool wxXmlResource::LoadObject(wxObject*, wxWindow*, const wxString&,
const wxString&)
./frm/frmImport.cpp: In member function ‘void
frmImport::OnTextFilePreviewMore(wxCommandEvent&)’:
./frm/frmImport.cpp:823: warning: comparison between signed and
unsigned integer expressions
./frm/frmImport.cpp: In member function ‘void
frmImport::OnArchFilePathKillFocus(wxFocusEvent&)’:
./frm/frmImport.cpp:854: warning: taking address of temporary
./frm/frmImport.cpp: In member function ‘void
frmImport::OnArchFilePreviewMore(wxCommandEvent&)’:
./frm/frmImport.cpp:911: warning: comparison between signed and
unsigned integer expressions
./frm/frmImport.cpp: In member function ‘void
frmImport::OnColSettingCellChange(wxGridEvent&)’:
./frm/frmImport.cpp:1268: warning: unused variable ‘evcolnr’
./frm/frmImport.cpp: In member function ‘void frmImport::ImportData()’:
./frm/frmImport.cpp:2228: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:2354: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:2592: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:2814: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:1470: warning: unused variable ‘logwarn’
./frm/frmImport.cpp: In member function ‘void frmImport::GenColsPreview()’:
./frm/frmImport.cpp:3857: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:3882: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:3781: warning: unused variable ‘skipemptyline’
./frm/frmImport.cpp:4056: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:3426: warning: unused variable ‘errcount’
./frm/frmImport.cpp: In member function ‘bool
frmImport::GenCSVSQLData(wxString&, wxString&, wxString**, size_t,
wxDateTime&, int, int)’:
./frm/frmImport.cpp:4304: warning: cannot pass objects of non-POD type
‘class wxString’ through ‘...’; call will abort at runtime
./frm/frmImport.cpp:4196: warning: unused variable ‘pvgridrowidx’
./frm/frmImport.cpp: In member function ‘void
frmImport::InitWizardPage(frmImport::WizardPageNumber)’:
./frm/frmImport.cpp:4869: warning: enumeration value ‘INVALIDPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘ALLIMPPAGES’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘TARGETPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘SRCTYPEPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘SRCODBCPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘COLSETTINGPAGE’
not handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘DESTLOGPAGE’ not
handled in switch
./frm/frmImport.cpp: In member function ‘void
frmImport::ResetWizardPage(frmImport::WizardPageNumber)’:
./frm/frmImport.cpp:5001: warning: enumeration value ‘INVALIDPAGE’ not
handled in switch
./frm/frmImport.cpp:5001: warning: enumeration value ‘ALLIMPPAGES’ not
handled in switch
./frm/frmImport.cpp:5001: warning: enumeration value ‘TARGETPAGE’ not
handled in switch
./frm/frmImport.cpp:5001: warning: enumeration value ‘SRCTYPEPAGE’ not
handled in switch
./frm/frmImport.cpp:5001: warning: enumeration value ‘SRCODBCPAGE’ not
handled in switch
./frm/frmImport.cpp:5001: warning: enumeration value ‘COLSETTINGPAGE’
not handled in switch
./frm/frmImport.cpp:5001: warning: enumeration value ‘PROCESSPAGE’ not
handled in switch
./frm/frmImport.cpp: In member function ‘void frmImport::ResetColSettingPage()’:
./frm/frmImport.cpp:5446: error: expected `}' before ‘else’
./frm/frmImport.cpp:5446: error: expected `}' before ‘else’
./frm/frmImport.cpp: At global scope:
./frm/frmImport.cpp:5446: error: expected unqualified-id before ‘else’
./frm/frmImport.cpp:5449: error: expected declaration before ‘}’ token

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Attachment Content-Type Size
mac.diff application/octet-stream 1.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Quan Zongliang 2009-12-23 13:26:47 Re: import: source code is pushed to git repository
Previous Message Dave Page 2009-12-22 21:08:37 Re: import: source code is pushed to git repository