Re: Application name patch - v3

Hi Andres,

On Thu, Nov 12, 2009 at 11:32 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I had some free time so I started to take a look at that patch:
>
> + PostgresPollingStatusType
> + pqAppnamePoll(PGconn *conn)
> ...
> +                       case APPNAME_STATE_OPTION_WAIT:
> ...
> +                               else
> +                               {
> +                                       /* Query finished, so we're done */
> +                                       conn->setenv_state = APPNAME_STATE_IDLE;
> +                                       return PGRES_POLLING_OK;
> +                               }
> +                               break;
> +                       }
> Shouldnt that set appname_state?

Yup, well spotted.

> The attached patch fixes this and also a couple occurances of trailing
> whitespace.

Thanks.

> What about pg_dump/psql setting fallback_application_name?

Per Tom, I'm waiting on the possible new array-based libpq connect API
which will make a conversion of those utilities from PQsetdbLogin a
lot cleaner than moving to PQconnectdb (and all the ugly connection
string building that would require).

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com