Re: pgAdmin and Slony

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin and Slony
Date: 2009-09-03 07:37:22
Message-ID: 937d27e10909030037n2d761b5bjb43c8ffc8e4043b2@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Sep 3, 2009 at 8:20 AM, Sachin
Srivastava<sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
> Dave,
>
> * pgAdmin code not up-to-date with latest Slony versions.
>
> Attached is a patch for updating pgAdmin code for Slony latest version.

OK, quick eyeball review:

- bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)

should be:

bool dlgRepCluster::SlonyMaximumVersion(const wxString &series, long minor)

- Just reading the patch, it looks like we never try to load xxid*.sql
any more. That's surely wrong?

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Magnus Hagander 2009-09-03 07:52:45 Fwd: Copy out wording
Previous Message Sachin Srivastava 2009-09-03 07:20:35 pgAdmin and Slony