Re: Patch for "Panel for Joins in the Graphic Query Builder"

Hi Ashesh

On Mon, Dec 1, 2008 at 10:41 AM, Ashesh D Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:

> Modifications and addition are as follows:
> * Introduced couple of new classes for handling operations:
> + gqbJoinsPanel - Panel for handling the joins in the tab - container for
> criteria, order & columns panels
> + gqbJoinsPopUp - Pop up window, when selecting a column from the table
> list,
> derived from the gqbColsPopUp
> + gqbGridJoinTable - Table for handling all the joins data. It handles
> three
> columns Source, Join-Type & Destination
> * Added new images gqbAdd.xpm & gqbRemove.xpm
> * Renamed wxRestrictionGrid to gqbCustomGrid as we're using the same Grid
> for
> handling the criteria(s) and join(s) in the gqbCriteriaPanel and
> gqbJoinsPanel
> respectively.
> * Added one operator [] in gqbArrayCollection for accessing the gqbObject
> object
> directory (replacement/accessibility of the object at particular index
> will be
> easy and fast).
> * Removed the context menu "Set Type" removed for join, as this operation
> will be
> handled from the joins-panel now onwards.

Wow - that's a whole lot more code than I was expecting (and explains
why it took somewhat longer than I planned). What I meant, was that I
just wanted a replacement dialogue for the existing one. What you've
done is reimplement the join handling, in what I think is a *much*
nicer way :-)

The only issues I've seen while testing (on Windows), are:

- The Join label doesn't update on the diagram if you change the join
type unless you click on the drawing canvas afterwards.

- Selecting a join should select the corresponding row in the list.

- You are missing updates to include/images/module.mk and
include/gqb/module.mk. The images should also be added to the VC++
project file.

Nice work!

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com