From: | "Dave Page" <dpage(at)pgadmin(dot)org> |
---|---|
To: | "Gianni Ciolli" <gianni(dot)ciolli(at)2ndquadrant(dot)it> |
Cc: | "Josh Berkus" <josh(at)agliodbs(dot)com>, pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: new patch (was Re: Status check: Ibrar, Gianni, Matthew) |
Date: | 2008-11-27 15:02:30 |
Message-ID: | 937d27e10811270702h61f55640u46c90099f6d1e4e7@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-rrreviewers |
Hi Gianni
On Thu, Nov 27, 2008 at 2:35 PM, Gianni Ciolli
<gianni(dot)ciolli(at)2ndquadrant(dot)it> wrote:
> On Wed, Nov 26, 2008 at 09:30:22AM +0000, Dave Page wrote:
>> Could you look at the posix_fadvise patch please?
>
> Hi Dave,
>
> if I'm correct, it looks like the posix_fadvise patch has been already
> reviewed some days ago, the reviewer made some suggestions, and the
> author is examining them.
>
> Perhaps you meant another patch? Or you are suggesting that there
> should be a multiple/collective review for that patch?
Multiple reviews. The existing review was largely a code style review,
but didn't cover any sort of perf testing etc. Plus it's always good
to get a second opinion :-)
The update to the patch should be posted today, but that is just a few
lines to remove a configure test I'm told. The server code will be
unchanged.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2008-11-27 19:00:04 | Re: new patch |
Previous Message | Gianni Ciolli | 2008-11-27 14:35:50 | new patch (was Re: Status check: Ibrar, Gianni, Matthew) |