| From: | "Dave Page" <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Radek Strnad" <radek(dot)strnad(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP patch: Collation support |
| Date: | 2008-09-23 10:26:23 |
| Message-ID: | 937d27e10809230326g168a7559r5609a2f2b0fda8b7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 23, 2008 at 10:20 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Committed.
*adds yet another item to his pgAdmin todo list* :-(
> Tom Lane wrote:
>>
>> * You should try to get rid of LOCALE_NAME_BUFLEN altogether. Definitely
>> the comment about it in pg_control.h is now obsolete.
>
> Yep. I removed LOCALE_NAME_BUFLEN. The real max length of a locale name is
> now NAMEDATALEN, because it's stored in a name field in pg_database.
> NAMEDATALEN is only 64 bytes, whereas LOCALE_NAME_BUFLEN was 128. 64 bytes
> should be enough for "en_GB.UTF8" style locale names, but I wonder if it's
> enough for the longer names used on Windows? Could someone confirm that,
> please?
The longest I can find is:
Serbian (Cyrillic)_Bosnia and Herzegovina
at 42 characters.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Martijn van Oosterhout | 2008-09-23 10:26:52 | Re: WIP patch: Collation support |
| Previous Message | Heikki Linnakangas | 2008-09-23 09:20:49 | Re: WIP patch: Collation support |