Re: pgScript patch

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Mickael Deloison" <mdeloison(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgScript patch
Date: 2008-08-06 18:06:15
Message-ID: 937d27e10808061106x2f2f19cejed9c9fdd99c2d469@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Wed, Aug 6, 2008 at 6:57 PM, Mickael Deloison <mdeloison(at)gmail(dot)com> wrote:

> Indeed, I am using virtual methods. Is there any reasons why you
> compiled with -fno-rtti ? Do I have to use wxWidgets RTTI capabilities
> instead of C++ built-in capabilities?

I think it was probably paranoia about overhead from including rtti
info. We rarely use the wxWidgets code - pretty much everywhere in the
pgAdmin code where we cast things about, it's from one child of
pgObject to another. We keep our own meta type id in each object
variation so we can know when to cast safely.

If there's no major difference in binary size etc. from enabling rtti,
I don't object to doing so.

> Weird, as the previous problem I need to look deeper at that in the
> next following days.

:-)

> About the documentation, I thought about adding information about the
> pgScript button in the Query page and a link to the (possibly
> reformated) syntax reference.

Agree on the button. I'd like to see the syntax reference as a
separate page in the docs though, not a link to an external site.

> About this syntax reference, how did you
> find it? Was it clear?

Clear, but could use a handful of good examples :-)

Keep up the good work!

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Lucas 2008-08-07 02:36:34 Layout Suggestion
Previous Message Mickael Deloison 2008-08-06 17:57:37 Re: pgScript patch