| From: | "Dave Page" <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | "Guillaume Lelarge" <guillaume(at)lelarge(dot)info> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: A fix and a new functionnality for the colour patch |
| Date: | 2008-06-16 20:15:55 |
| Message-ID: | 937d27e10806161315pa99267y1cf3e4313c7f0730@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Jun 16, 2008 at 9:03 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Dave Page a écrit :
>>
>> On Sat, Jun 14, 2008 at 4:21 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>> [...]
>>>
>>> Comments?
>>
>> You spelt colour wrong :-). Other than that (and the possible issue
>> above), looks good.
>>
>
> Can I commit this patch?
Sure. As a general rule if there are no objections within a couple of
days I say go for it. You're experienced in the code now, and we can
always fix any problems that may arise.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2008-06-16 20:34:33 | Re: Enabling SQL text field in the SQL tab of object dialog |
| Previous Message | Dave Page | 2008-06-16 20:12:58 | Re: Enabling SQL text field in the SQL tab of object dialog |