postgres_fdw: correct regression test for parameterized scan for foreign table

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: postgres_fdw: correct regression test for parameterized scan for foreign table
Date: 2017-03-21 11:21:11
Message-ID: 93684211-1f78-514f-84a7-c6b434a0921a@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While working on adding support for parameterized foreign joins to
postgres_fdw, I noticed that commit
e4106b2528727c4b48639c0e12bf2f70a766b910 forgot to modify a test query
for execution of a parameterized foreign scan for a foreign table:

--- parameterized remote path
+-- parameterized remote path for foreign table
EXPLAIN (VERBOSE, COSTS false)
- SELECT * FROM ft2 a, ft2 b WHERE a.c1 = 47 AND b.c1 = a.c2;
+ SELECT * FROM "S 1"."T 1" a, ft2 b WHERE a."C 1" = 47 AND b.c1 = a.c2;
SELECT * FROM ft2 a, ft2 b WHERE a.c1 = 47 AND b.c1 = a.c2;

The query in the last line as-is would test to see if the remote join
works correctly, which isn't the right thing to do here. Attached is a
small patch for addressing that.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
postgresql-fdw-regress.patch binary/octet-stream 2.7 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-03-21 11:41:25 Re: Partition-wise join for join between (declaratively) partitioned tables
Previous Message Thomas Munro 2017-03-21 11:17:58 Problem in Parallel Bitmap Heap Scan?