| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, MauMau <maumau307(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [patch] pg_copy - a command for reliable WAL archiving |
| Date: | 2014-08-20 14:19:33 |
| Message-ID: | 9368.1408544373@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-08-20 09:50:56 -0400, Alvaro Herrera wrote:
>> Andres Freund wrote:
>>> Isn't this a solution looking for a problem? We're using tempfiles in
>>> dozens of other places and I really don't see why this is the place to
>>> stop doing so. Just copy to <dest>.tmp and move it into place.
>> The issue is what happens if there's a crash while the temp file is in
>> the middle of being filled.
> The archive command will be be run again a couple seconds and remove the
> half-filled temp file.
Alternatively, you could use the process PID as part of the temp file
name; which is probably a good idea anyway.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-08-20 14:27:46 | Re: [patch] pg_copy - a command for reliable WAL archiving |
| Previous Message | Amit Kapila | 2014-08-20 14:19:00 | Re: pg_basebackup vs. Windows and tablespaces |