| From: | "Gokulakannan Somasundaram" <gokul007(at)gmail(dot)com> |
|---|---|
| To: | "Gregory Stark" <stark(at)enterprisedb(dot)com> |
| Cc: | "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "pgsql-hackers list" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal for Null Bitmap Optimization(for TrailingNULLs) |
| Date: | 2007-12-17 18:35:43 |
| Message-ID: | 9362e74e0712171035q4c5638eajbb3be6b9bd3ec9bb@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Hi,
I made the fix and tested it today. It involved some 10-15 lines of code
change. I will mail it tomorrow. Feel free to give suggestions on making the
fix more maintainable.
I have followed Gregory's advice in the fix - Instead of changing the
slot_deform_tuple, i have reduced the number of attributes field of the
HeapTupleHeader(during insertion), so that the trailing nulls are treated
the same as newly added columns. Thanks Gregory.
Regarding arrangement of the columns, my take is to leave it to the user
on the arrangement of the columns. May be we can put some kind of tuning
hint somewhere in our document on the suggestions. I have made the above
statement, without thinking about other advantages, if any.
--
Thanks,
Gokul.
CertoSQL Project,
Allied Solution Group.
(www.alliedgroups.com)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-12-17 20:23:21 | Re: Board for developers |
| Previous Message | Joshua D. Drake | 2007-12-17 18:14:21 | Re: [HACKERS] Board for developers |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2007-12-17 20:17:17 | patch to disallow zero length paths in binary (minor bug fix) |
| Previous Message | Gregory Stark | 2007-12-17 14:52:59 | Re: Proposal for Null Bitmap Optimization(for TrailingNULLs) |