Re: FW: PGBuildfarm member snake Branch HEAD Status changed

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FW: PGBuildfarm member snake Branch HEAD Status changed
Date: 2005-10-01 17:13:49
Message-ID: 9351.1128186829@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Alvaro Herrera wrote:
>> Here, the culprits are tfind() and tsearch(). These apparently aren't
>> "portable enough", but they seem to exist on all other platforms. Maybe
>> we could come up with a replacement on Windows? Are there simple
>> btree/hash table functions on Windows, with a similar API?

> The library found at
> http://sourceforge.net/project/shownotes.php?release_id=209006 seems to
> have what is needed, but I really don't think we can impose that extra
> requirement at this stage of the release cycle, do you? ISTM either we
> need to revert this or change it to use an API that is already known to
> be supported.

Yeah, I was wondering about those functions too when I looked at the
patch. ISTM that this is overkill anyway; I cannot imagine anyone
writing a pgbench script with more than a few variables. So I'd
recommend ripping out the <search.h> stuff altogether and just making a
linear search through a simple array of variables.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-10-01 17:16:38 Re: Expression index ignores column statistics target
Previous Message Tom Lane 2005-10-01 17:02:29 Re: [PATCHES] Proposed patch for sequence-renaming problems