| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-10-02 21:15:15 |
| Message-ID: | 931B78E3-7608-4A14-A3DD-E83B4396E8C2@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 2 Oct 2025, at 23:00, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
>> since that is a STRICT function, making the test for NULL superfluous code:
>
> I didn't notice that was marked as strict. It would be good to get rid
> of those lines in that case.
Done, comment cleanup and nullness check pushed.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-10-02 21:31:48 | Re: disallow big-endian on aarch64 |
| Previous Message | Tom Lane | 2025-10-02 21:08:42 | Re: disallow big-endian on aarch64 |