| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: comment fix in postmaster.c |
| Date: | 2021-03-16 09:27:53 |
| Message-ID: | 930923b4-a053-4bb5-5e91-b1d5e2985ef7@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/03/16 16:51, Kyotaro Horiguchi wrote:
> While I worked on a patch, I noticed a comment that is inconsistent
> with the fact.
>
>> * SIGQUIT is the special signal that says exit without proc_exit
>> * and let the user know what's going on. But if SendStop is set
>> * (-s on command line), then we send SIGSTOP instead, so that we
>> * can get core dumps from all backends by hand.
>
> SendStop is set by "-T" option. It was changed by 86c23a6eb2 from "-s"
> in 2006.
>
> The attaches fixes the comment for the master branch.
Thanks for the path! LGTM. Barring any objection, I will push the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-03-16 09:38:04 | Re: A new function to wait for the backend exit after termination |
| Previous Message | gkokolatos | 2021-03-16 09:13:51 | Re: Allow batched insert during cross-partition updates |