Re: XML binary I/O (was Re: tsearch refactorings)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: "Patches" <pgsql-patches(at)postgresql(dot)org>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>
Subject: Re: XML binary I/O (was Re: tsearch refactorings)
Date: 2007-09-23 21:38:40
Message-ID: 9272.1190583520@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
> Here's a patch that fixes the send/recv functions to work like the
> manual says. It fixes the free/pfree typo as well.

Applied with a further fix: the patch caused xml_recv to call
parse_xml_decl with a non-null-terminated string, which could in the
worst case lead to a crash.

> Included is a new regression test for the send/recv functions as well

I didn't apply this, as it seemed more trouble than it was worth.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-09-23 23:01:46 remove convert using
Previous Message Tom Lane 2007-09-23 20:48:10 Re: Optimizer hook