Re: why doesn't DestroyPartitionDirectory hash_destroy?

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: why doesn't DestroyPartitionDirectory hash_destroy?
Date: 2019-03-14 07:46:47
Message-ID: 925f5533-d122-a3ba-f00e-88e99eff70b1@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019/03/14 16:32, Kyotaro HORIGUCHI wrote:
> At Thu, 14 Mar 2019 16:13:23 +0900, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote in <3ad792cd-0805-858e-595c-c09e9d1ce042(at)lab(dot)ntt(dot)co(dot)jp>
>> Hi,
>>
>> I'm curious why DestroyPartitionDirectory doesn't do
>> hash_destroy(pdir->pdir_hash)?
>
> Maybe it is trashed involved in destruction of es_query_cxt or
> planner_cxt?

Hmm, the executor's partition directory (its hash table) is indeed
allocated under es_query_cxt. But, the planner's partition directory is
not allocated under planner_cxt, it appears to be using memory under
MessageContext.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-03-14 07:48:09 Re: Fix volatile vs. pointer confusion
Previous Message Mitar 2019-03-14 07:41:49 Re: Implementing Incremental View Maintenance