| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Ilya Gladyshev <i(dot)gladyshev(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Partial aggregates pushdown |
| Date: | 2022-01-17 12:27:53 |
| Message-ID: | 925e2d3f11283d8b2707fc5d827fc3e9@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alexander Pyhalov писал 2022-01-17 15:26:
> Zhihong Yu писал 2022-01-17 11:43:
>> Hi,
>> + FdwScanPrivateConvertors
>>
>> + * Generate attinmeta if there are some converters:
>>
>> I think it would be better if converter is spelled the same way across
>> the patch.
>>
>> For build_conv_list():
>>
>> + if (IS_UPPER_REL(foreignrel))
>>
>> You can return NIL for !IS_UPPER_REL(foreignrel) - this would save
>> indentation for the body of the func.
>
> Hi.
> Updated patch.
Sorry, missed attachment.
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Partial-aggregates-push-down-v09.patch | text/x-diff | 57.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-01-17 12:30:22 | Re: row filtering for logical replication |
| Previous Message | Alexander Pyhalov | 2022-01-17 12:26:55 | Re: Partial aggregates pushdown |