Re: Partial aggregates pushdown

From: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Ilya Gladyshev <i(dot)gladyshev(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Partial aggregates pushdown
Date: 2022-01-17 12:26:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Zhihong Yu писал 2022-01-17 11:43:
> Hi,
> + FdwScanPrivateConvertors
> + * Generate attinmeta if there are some converters:
> I think it would be better if converter is spelled the same way across
> the patch.
> For build_conv_list():
> + if (IS_UPPER_REL(foreignrel))
> You can return NIL for !IS_UPPER_REL(foreignrel) - this would save
> indentation for the body of the func.

Updated patch.

Best regards,
Alexander Pyhalov,
Postgres Professional

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Pyhalov 2022-01-17 12:27:53 Re: Partial aggregates pushdown
Previous Message Daniel Gustafsson 2022-01-17 12:26:33 Re: New developer papercut - Makefile references INSTALL