Re: Worth using personality(ADDR_NO_RANDOMIZE) for EXEC_BACKEND on linux?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Worth using personality(ADDR_NO_RANDOMIZE) for EXEC_BACKEND on linux?
Date: 2021-08-11 12:38:43
Message-ID: 925cbc86-04e9-d1ed-dcd0-ab6653a6b2c2@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 8/10/21 7:59 PM, Thomas Munro wrote:
> On Wed, Aug 11, 2021 at 7:07 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> On Wed, Aug 11, 2021 at 2:12 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>>> On Tue, Aug 10, 2021, at 15:19, Thomas Munro wrote:
>>>> Yeah, make check always fails for me on macOS 11. With the attached
>>>> experimental hack, it fails only occasionally (1 in 8 runs or so). I
>>>> don't know why.
>>> I suspect you'd need to use the hack in pg_ctl to make it reliable. The layout of normally stayed position independent postmaster can be incompatible with the non ASLR spawned child.
>> Yeah, but the patch already changes both pg_ctl.c and postmaster.c.
> /me stares at vmmap output for a while
>
> Oooh. It's working perfectly (for example if you export
> PATH=binarys:$PATH, pg_ctl -D pgdata start, make installcheck), but
> pg_regress.c has its own separate fork/exec to launch the temporary
> cluster that needs to be similarly hacked.

initdb also runs postgres a bunch of times via system(), similarly to
pg_regress but without the "exec". Does it also need adjusting?

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-08-11 12:44:55 Re: [BUG]Update Toast data failure in logical replication
Previous Message Greg Nancarrow 2021-08-11 12:32:15 Re: Parallel scan with SubTransGetTopmostTransaction assert coredump