Re: initdb: Refactor PG_CMD_PUTS loops

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: initdb: Refactor PG_CMD_PUTS loops
Date: 2022-12-05 22:40:54
Message-ID: 924d08b2-0fb0-a97e-2e2e-7c365ea42f0c@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02.12.22 15:07, Andrew Dunstan wrote:
> On 2022-12-01 Th 05:02, Peter Eisentraut wrote:
>> Keeping the SQL commands that initdb runs in string arrays before
>> feeding them to PG_CMD_PUTS() seems unnecessarily verbose and
>> inflexible.  In some cases, the array only has one member.  In other
>> cases, one might want to use PG_CMD_PRINTF() instead, to parametrize a
>> command, but that would require breaking up the loop or using
>> workarounds like replace_token().  This patch unwinds all that; it's
>> much simpler that way.
>
> Looks reasonable. (Most of this dates back to 2003/2004, the very early
> days of initdb.c.)

committed

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-12-05 23:07:47 Re: Transaction timeout
Previous Message Nikolay Samokhvalov 2022-12-05 22:28:35 Re: Transaction timeout