| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Marcos Magueta <maguetamarcos(at)gmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIP - xmlvalidate implementation from TODO list |
| Date: | 2026-02-22 11:44:01 |
| Message-ID: | 9228b6dc-cfae-4a11-927a-209680f5507e@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Marcos
On 22/02/2026 06:11, Marcos Magueta wrote:
>> Unfortunately, the patch no longer applies.[1]
> Trying to understand why it doesn't, we can get back to that.
I think the cfbot is confused about the ordering of your patch set. You
labelled the files as
* v5-0002-Add-XMLVALIDATE.patch
* v6-0001-Add-CREATE-XMLSCHEMA.patch
which generates two issues:
1) both of them should have the save version, i.e v5 or v6.
2) the XMLVALIDATE patch depends on CREATE XMLSCHEMA, and the files
order right now suggest quite the opposite. The next iteration should be:
* v7-0001-Add-CREATE-XMLSCHEMA.patch
* v7-0002-Add-XMLVALIDATE.patch
Best, Jim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-02-22 12:34:35 | Re: COMMENTS are not being copied in CREATE TABLE LIKE |
| Previous Message | Amit Kapila | 2026-02-22 11:20:57 | Re: Skipping schema changes in publication |