From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Hao Zhang <zhrt1446384557(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] plpython function causes server panic |
Date: | 2024-03-22 15:51:00 |
Message-ID: | 920167.1711122660@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Dec 29, 2023 at 12:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Here's a draft patch along this line. Basically the idea is that
>> subtransactions used for error control are now legal in parallel
>> mode (including in parallel workers) so long as they don't try to
>> acquire their own XIDs. I had to clean up some error handling
>> in xact.c, but really this is a pretty simple patch.
> I agree with the general direction. A few comments:
Thanks for looking at this! I was hoping you'd review it, because
I thought there was a pretty significant chance that I'd missed some
fundamental reason it couldn't work. I feel better now about it
being worth pursuing.
I consider the patch draft quality at this point: I didn't spend
much effort on docs or comments, and none on test cases. I'll
work on those issues and come back with a v2.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-03-22 16:28:40 | Re: sublink [exists (select xxx group by grouping sets ())] causes an assertion error |
Previous Message | David G. Johnston | 2024-03-22 15:50:21 | Re: documentation structure |