| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: appendBinaryStringInfo stuff |
| Date: | 2022-12-19 15:12:25 |
| Message-ID: | 920036.1671462745@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> I'm currently not sure why the macro trick increases the binary at
> all. I understand why the inline function does.
In the places where it changes the code at all, you're replacing
appendStringInfoString(buf, s);
with
appendBinaryStringInfo(buf, s, n);
Even if n is a constant, the latter surely requires more instructions
per call site.
Whether this is a win seems to depend on how many of these are
performance-critical.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-12-19 15:20:45 | Re: meson files copyright |
| Previous Message | Andrew Dunstan | 2022-12-19 14:52:45 | Avoid generating SSL certs for LDAP tests |