| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Zuelke <dz(at)heroku(dot)com> |
| Subject: | Re: Fix for OpenSSL error queue bug |
| Date: | 2016-05-03 02:06:38 |
| Message-ID: | 9200.1462241198@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 04/27/2016 11:04 PM, Tom Lane wrote:
>> Actually, git_changelog can merge identically-messaged commits despite
>> intervening commits. It's set up to not merge commits more than 24 hours
>> apart, though. We could loosen that requirement but I'm afraid it would
>> make things confusing to merge far-apart commits.
> ISTM that git_changelog should be looking at the AuthorDate instead of
> the CommitDate. Then it would work correctly for backpatches done using
> cherry-pick.
Meh. That would also make it noticeably *less* accurate for some other
scenarios. It actually did look at AuthorDate to start with, and we
changed it because we didn't like the results; cf 7299778a9.
Also, IME, backpatching with cherry-pick fails often enough that designing
one's process around it is just asking for pain. Certainly, many fewer
than half of my own back-patches manage to use cherry-pick.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-05-03 02:22:29 | Re: About subxact and xact nesting level... |
| Previous Message | Peter Eisentraut | 2016-05-03 01:47:54 | Re: Fix for OpenSSL error queue bug |