| From: | Jan Wieck <jan(at)wi3ck(dot)info> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Robins Tharakan <tharakan(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade failing for 200+ million Large Objects |
| Date: | 2021-03-23 12:51:32 |
| Message-ID: | 91ccdb0d-42fd-7413-4e7c-3d6445655d2e@wi3ck.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/22/21 7:18 PM, Jan Wieck wrote:
> On 3/22/21 5:36 PM, Zhihong Yu wrote:
>> Hi,
>>
>> w.r.t. pg_upgrade_improvements.v2.diff.
>>
>> + blobBatchCount = 0;
>> + blobInXact = false;
>>
>> The count and bool flag are always reset in tandem. It seems
>> variable blobInXact is not needed.
>
> You are right. I will fix that.
New patch v3 attached.
Thanks, Jan
--
Jan Wieck
Principle Database Engineer
Amazon Web Services
| Attachment | Content-Type | Size |
|---|---|---|
| pg_upgrade_improvements.v3.diff | text/x-patch | 22.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-03-23 12:53:18 | Re: Wired if-statement in gen_partprune_steps_internal |
| Previous Message | Christoph Berg | 2021-03-23 11:50:29 | Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres |