Re: pgsql: Clean up warnings from -Wimplicit-fallthrough.

On 5/1/18 23:33, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On 2018-05-01 23:35:18 +0000, Tom Lane wrote:
>>> Clean up warnings from -Wimplicit-fallthrough.
>
>> I found one more oddity with the current committed state: ...
>> It seems that gcc gets confused by the #ifdef ECONNRESET.
>
> Yeah, there's a gcc bug or three about that:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77817
>
>> ... But the nicer fix seems to be to move the
>> FALL THRU into the ifdef, which even seems more correct when nitpicking
>> in god mode.
>
> I thought about that, and didn't like it much. I hoped maybe the gcc guys
> would fix it soon, but after reading their bugzilla entry more closely,
> it sounds like we shouldn't hold our breath. So if you want to do it
> like that, OK by me.

It sounds like we have a handle on all the potential issues for now, so
I think it would be OK to add this warning to the standard set on master.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services