| From: | Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: VM corruption on standby |
| Date: | 2025-08-19 12:56:05 |
| Message-ID: | 91495849-ebf7-4f7e-8cca-ec718964d256@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
09.08.2025 22:54, Kirill Reshke пишет:
> On Thu, 7 Aug 2025 at 21:36, Aleksander Alekseev
> <aleksander(at)tigerdata(dot)com> wrote:
>
>> Perhaps there was a good
>> reason to update the VM *before* creating WAL records I'm unaware of.
>
> Looks like 503c730 intentionally does it this way; however, I have not
> yet fully understood the reasoning behind it.
I repeat: there was no intention. Neither in commit message, nor in
discussion about.
There was intention to move visibilitymap_clear under heap page lock and
into critical section, but there were no any word about logging.
I believe, it was just an unfortunate oversight that the change is made
before logging.
--
regards
Yura Sokolov aka funny-falcon
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-08-19 13:09:53 | Re: VM corruption on standby |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-08-19 12:52:24 | RE: ReplicationSlotRelease() crashes when the instance is in the single user mode |