Re: pgsql: Add support for hyperbolic functions, as well as log10().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, laetitia(dot)avrot(at)gmail(dot)com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: 2019-03-16 19:51:37
Message-ID: 9124.1552765897@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 3/14/19 3:08 PM, Tom Lane wrote:
>> I feel therefore that what we should do (barring new evidence) is either
>> 1. Remove all the inf/nan test cases for the hyoerbolic functions ...
>> 2. Just comment out the one failing test, with a note about why.

> 2. would help us memorialize the problem.

Hearing no other comments, done that way.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-03-16 21:53:54 pgsql: Remove another unnecessary application_name specification in tes
Previous Message Tom Lane 2019-03-16 19:50:22 pgsql: Further adjust the tests for the hyperbolic functions.

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2019-03-16 20:05:08 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons
Previous Message Mark G 2019-03-16 18:54:18 Keyword table constness in jsonpath scanner.