| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make #else/#endif comments more consistent |
| Date: | 2022-08-29 11:50:09 |
| Message-ID: | 9111f9f3-0f77-785a-a933-eb62492714ca@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29.08.22 11:38, Anton Voloshin wrote:
> I propose making them more consistent. Would the following guidelines be
> acceptable?
I usually try to follow the guidelines in
<https://www.gnu.org/prep/standards/html_node/Comments.html>, which
pretty much match what you are proposing.
> And this:
> #else /* !_MSC_VER */
> over
> #else /* !defined(_MSC_VER) */
Note that for _MSC_VER in particular there is some trickiness: We
generally use it to tell apart different MSVC compiler versions. But it
is not present with MinGW. So !_MSC_VER and !defined(_MSC_VER) have
different meanings. So in this particular case, more precision in the
comments might be better.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-08-29 11:51:44 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Daniel Gustafsson | 2022-08-29 11:46:25 | Re: pg_checksum: add test for coverage |