| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| Date: | 2018-08-23 00:16:24 |
| Message-ID: | 9102.1534983384@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
Andres Freund <andres(at)anarazel(dot)de> writes:
> There's a few further potential cleanups due to relying on c99:
> - Use __func__ unconditionally, rather than having configure test for it
> - Use inline unconditionally, rather than having configure test for it
> - Remove tests for AC_TYPE_INTPTR_T, AC_TYPE_UINTPTR_T,
> AC_TYPE_LONG_LONG_INT, we can rely on them being present.
> - probably more in that vein
I wouldn't be in too much of a hurry to do that, particularly not the
third item. You are confusing "compiler is c99" with "system headers
are c99". Moreover, I don't see that we're buying much with such
changes.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-08-23 00:19:32 | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| Previous Message | Andres Freund | 2018-08-23 00:09:05 | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-08-23 00:19:32 | Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c) |
| Previous Message | Steve Atkins | 2018-08-23 00:12:31 | Re: postgresql-archive.org |