| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: postgres_fdw insert batching |
| Date: | 2021-01-21 00:46:29 |
| Message-ID: | 90b0e85d-9db9-5e47-7746-5afba5ee8185@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/21/21 12:59 AM, Tom Lane wrote:
> Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
>> OK, pushed after a little bit of additional polishing (mostly comments).
>> Thanks everyone!
>
> florican reports this is seriously broken on 32-bit hardware:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=florican&dt=2021-01-20%2023%3A08%3A15
>
> First guess is incorrect memory-allocation computations ...
>
I know, although it seems more like an access to unitialized memory.
I've already posted a patch that resolves that for me on 64-bits (per
valgrind, I suppose it's the same issue).
I'm working on reproducing it on 32-bits, hopefully it won't take long.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-01-21 00:56:25 | Re: POC: postgres_fdw insert batching |
| Previous Message | Kyotaro Horiguchi | 2021-01-21 00:29:59 | Re: Printing LSN made easy |