Re: pg_createsubscriber TAP test wrapping makes command options hard to read.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: 2025-01-26 14:12:49
Message-ID: 90a80cee-f13e-48db-bad9-c86ffdd2abcc@dunslane.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-01-26 Su 9:02 AM, Andrew Dunstan wrote:
>
>
>
>
> This seems to me like the wrong fix. We don't want to create
> "no_such_user" I think, we just want to catch the Windows error
> message, as in this patch.
>
>
>

Ignore this ... I'm clearly insufficiently caffeinated this morning.
Despite the name, this doesn't actually create the role, so the proposed
fix would be fine, I think.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Srinath Reddy 2025-01-26 14:24:45 Re: Why we need to check for local buffers in BufferIsExclusiveLocked and BufferIsDirty?
Previous Message Andrew Dunstan 2025-01-26 14:02:02 Re: pg_createsubscriber TAP test wrapping makes command options hard to read.