From: | Bernd Helmle <mailings(at)oopsware(dot)de> |
---|---|
To: | Greg Smith <greg(at)2ndquadrant(dot)com>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Robert(dot)Lor(at)Sun(dot)COM, jesus(at)omniti(dot)com |
Subject: | Re: [patch] executor and slru dtrace probes |
Date: | 2009-12-15 22:10:36 |
Message-ID: | 90EAEBC221850A39B4AB556D@amenophis |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
--On 15. Dezember 2009 12:10:09 -0500 Greg Smith <greg(at)2ndquadrant(dot)com>
wrote:
> But I'm afraid we're already out of time for this one if you're still
> tweaking the probes here. With a functional change like that, our
> normal process at this point would be to have the reviewer re-evaluate
> things before they head to a committer, and I don't feel like this patch
> is quite at 100% yet--in particular, the probe documentation is improving
> but still a bit rough. I don't feel like we're quite ready to mark this
> one for commit for this one, and today we really want to clear the queue
> for things for committers to deal with. Please send that updated
> version, and let's keep working on this into the next CommitFest, where
> it will be in the front of the queue rather than how it ended up at the
> tail of this one just based on its submission date. You're not really
> getting a fair chunk of time here between your review and the end here
> because of problems lining up reviewer time, that shouldn't happen next
> time.
That seems reasonable.
I hope i could contribute something, even this was the first time i got my
hands on reviewing this DTrace thingie.
--
Thanks
Bernd
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-12-15 22:17:30 | Re: Range types |
Previous Message | Marko Kreen | 2009-12-15 22:09:30 | Re: Patch: Remove gcc dependency in definition of inline functions |