Re: `make check` doesn't pass on MacOS Catalina

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Gurjeet Singh <gurjeet(at)singh(dot)im>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: `make check` doesn't pass on MacOS Catalina
Date: 2022-08-06 14:41:09
Message-ID: 9096.1659796869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2022-08-06 Sa 06:49, Gurjeet Singh wrote:
>> There are no comments as to why one should choose to use --delay-check
>> ($delay_check). This email, and the pointer to the paragraph buried in
>> the docs, shared by Tom, are the only two ways one can understand what
>> is causing this failure, and how to get around it.

> In general we want to run "make check" as soon as possible after running
> "make" on the core code. That's why I didn't simply delay it
> unconditionally.

In general --- that is, on non-broken platforms --- "make check"
*should* work without a prior "make install". I am absolutely
not in favor of changing the buildfarm so that it fails to detect
the problem if we break that. But for sure it'd make sense to add
some comments to the wiki and/or sample config file explaining
that you need to set this option on systems X,Y,Z.

On macOS you need to use it if you haven't disabled SIP.
I don't have the details about any other problem platforms.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-08-06 14:47:25 Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)
Previous Message Zhang Mingli 2022-08-06 14:05:41 Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)