Re: [PATCH 1/1] Fix detection of pwritev support for OSX.

From: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: James Hilliard <james(dot)hilliard1(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
Date: 2021-01-23 08:27:16
Message-ID: 9073cad7-4422-9a3f-8473-871c70387026@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23.01.2021 08:02, Sergey Shinderuk wrote:
>> On the whole it looks like we should recommend installing the CLT
>> and not bothering with Xcode, which is about 10X the size:
>>
>> $ du -hs /Library/Developer/CommandLineTools
>> 1.1G    /Library/Developer/CommandLineTools
>> $ du -hs /Applications/Xcode.app
>>   15G    /Applications/Xcode.app
>>
>
> Fair.

BTW, Homebrew prefers the CLT SDK:
https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac.rb#L138

# Prefer CLT SDK when both Xcode and the CLT are installed.
# Expected results:
# 1. On Xcode-only systems, return the Xcode SDK.
# 2. On Xcode-and-CLT systems where headers are provided by the
system, return nil.
# 3. On CLT-only systems with no CLT SDK, return nil.
# 4. On CLT-only systems with a CLT SDK, where headers are
provided by the system, return nil.
# 5. On CLT-only systems with a CLT SDK, where headers are not
provided by the system, return the CLT SDK.

Here is the relevant discussion:
https://github.com/Homebrew/brew/pull/7134

I like the example of Git compiled against the wrong
LIBCURL_VERSION_NUM. Clearly, there are other issues with
cross-compiling to a newer SDK, besides autoconf probes and weak imports.

--
Sergey Shinderuk
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-01-23 08:31:18 Re: POC: postgres_fdw insert batching
Previous Message Bharath Rupireddy 2021-01-23 08:14:44 Re: Logical Replication - behavior of ALTER PUBLICATION .. DROP TABLE and ALTER SUBSCRIPTION .. REFRESH PUBLICATION