Re: Package version in PG_VERSION and version()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Package version in PG_VERSION and version()
Date: 2017-12-15 15:23:37
Message-ID: 9064.1513351417@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christoph Berg <christoph(dot)berg(at)credativ(dot)de> writes:
> Re: Michael Paquier 2017-12-15 <CAB7nPqTra6ZkPr0xTmHY0J4gmKwbStbMmaKMa9Kswb2bZxe=yw(at)mail(dot)gmail(dot)com>
>> Why reinventing the wheel when there is already --with-extra-version
>> that you can use for the same purpose?

> That modifies the PG version number as such, as what psql is showing
> on connect. I'd think that is too intrusive.

I'm really pretty much -1 on having two different ways to do very nearly
the same thing, with the differences determined only by somebody's
arbitrary choices of where they think the modified version should be
exposed. IMO, either you think the Debian package version is important
enough to show, or you don't. (I'd incline to the "don't" side anyway.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-12-15 15:29:26 Re: Reproducible builds: genbki.pl vs schemapg.h
Previous Message Pavel Stehule 2017-12-15 15:15:51 Re: [HACKERS] pgbench more operators & functions